OptimizedDirectorySourceLocator: optimize regex by strpos checks #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> try to fix reported errors by phpstan itself
-> try to fix the code style
-> try to fix reported errors by phpstan itself
|
Hi, this code comes from Composer, so 1) I wouldn't like to differ from the original too much, 2) I'd much rather have the Composer guys do the review :) The only difference is that the Composer version doesn't support functions because it doesn't make sense in their context (an autoloader) but it does in PHPStan's. The code in Composer is here: https://github.com/composer/composer/blob/c8731598ccc7d8050dc132b5891f7d15cc7bbc14/src/Composer/Autoload/ClassMapGenerator.php#L216 It's not exactly the same structure but the logic is the same. Can you please first submit the optimizations to Composer and after they're accepted, do the same ones here? Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I try to write a regex, it's faster if I don't need the regex at all. So, here's a simple string check before the regex magic.
This change is